Justin Deoliveira ha scritto: > Andrea Aime wrote: >> Justin Deoliveira ha scritto: >>> I think I agree with Jody in that you should probably use Hints >>> straight up... not because I love the hints api but for reasons of >>> consistency. >>> >>> AS for where to put hte honored hints... not too sure about that one >>> either. What about throwing another method on DataStoreFactory for it >>> called "getQueryHints()". Or maybe on DataStore? I guess >>> FeatureSource works too... >> >> I explained why Hints do not work in the proposal, anyone willing to >> challenge my (very limited) knowledge of them and provide some feedback? >> I would be happy to be proven wrong (really!). > Hmmm, you state that ClassKey is private... looking at the code i see it > as public. Or do you mean the constructor that takes a string?
Hmm... I've probably been tricked by the fact Hints uses only ClassKey and its package private constructor. > I do kind of agree that the idea of keys being based on the idea of a > class is kind of strange to me... So how about a middle ground of > returning Map<String,Object>. Its still more consistent with the > rendering hints stuff then getProperty/setProperty. No no, it's ok to use Hints.Key then, sorry for the mess, I definitely had a too cursory look at Hints. Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
