Justin Deoliveira ha scritto: > I think I agree with Jody in that you should probably use Hints straight > up... not because I love the hints api but for reasons of consistency.
Ok, I managed to understand my error, and you are both right. Will fix the proposal. > AS for where to put hte honored hints... not too sure about that one > either. What about throwing another method on DataStoreFactory for it > called "getQueryHints()". Or maybe on DataStore? I guess FeatureSource > works too... Hmmm... let's think about it for a moment then. DataStoreFactory.getQueryHints() would be the easier to fix, since this class is not implemented in a ton of variants (most factories have an abstract parent) and it's not wrapped up usually. But the code used to access it would be horrible, you have a FeatureSource, ask for a FeatureCollection, and then you have to instantiate the factory just for the sake of checking the hints, ugh! FeatureSource and FeatureCollection are a more natural place, but both have many implementations. FeatureSource seem to have the easiest to deal with because it has "only" 8 top level implementations where we could host a default null/emtpy set returning method. FeatureCollection has a few more, a dozen as far I as I can see (I'm speaking of 2.4.x here), but would have the advantage that the honored hints may be dependent on the actual query performed, whilst a method on FeatureSource could be only featuretype dependent. So, shall we add it to FeatureCollection? Cheers Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
