Hello Jesse, thanks for your credits. I am very happy to take part on the GeoTools development work.
I will try to commit my patches concerning the WFS Module tomorrow. That will be: - Synchronization Errors (FCBuffer) - Encoding Support on WFS-Request so that we can support also e.g. German-Umlauts in the Request. (WFSDatastore,WFSDatastoreFactory and DocumentWriter) - FIX for Timeout-Problems when e.g. a NumberformatExceptions occours (WFSFeatureReader). - Memory-Leak FIX in SAXHandler Will this be ok for you? Thanks a lot Tim -----Ursprüngliche Nachricht----- Von: Jesse Eichar [mailto:[EMAIL PROTECTED] Gesendet: Freitag, 31. August 2007 18:27 An: Jody Garnett Cc: Tim Englich; geotools-devel@lists.sourceforge.net Betreff: Re: [Geotools-devel] Horrible Synchronization Errors in FCBuffer I've reviewed at a number of Tim's patches and have been happy with their quality. If it is alright with Tim, I'd like to nominate him to be co-module-maintainer on the WFS module. Tim is that ok? This way you can apply the patch let me know and I can review it in place rather than finding time to apply it review it and finally apply it to all other branches. I'm simply too busy to do this in a timely fashion. +1 for commit access from me. Jesse On Aug 31, 2007, at 9:06 AM, Jody Garnett wrote: > Tim we do not have anyone to respond in a timely fashion on this > end ... > did you want to apply your patch and ensure all the tests work etc? > Jody >> Hello GeoToolers, >> >> we found a horrible synchronization-Error in the WFS-Plugin caused >> by the >> org.geotools.xml.gml.FCBuffer. >> >> Our Consumer get features twice or features are overriden by >> FCCodeBuffer >> before they are read from it. >> We have to change the synchronized-block in addFeature and next >> Methods to >> solve this issue. >> I send the manipulated code to you. >> Could anyone have a look at it and perhaps integrate the changes >> to the >> codebase. >> >> Thanks a lot >> Tim >> >> >> protected boolean addFeature(Feature f) { >> if (ft == null) { >> ft = f.getFeatureType(); >> } >> >> if (size >= features.length) { >> return false; >> } >> >> synchronized (this) { >> notify(); >> >> >> features[end] = f; >> end++; >> >> if (end == features.length) { >> end = 0; >> } >> >> size++; >> } >> return true; >> } >> >> public Feature next() >> throws IOException, NoSuchElementException { >> if (exception != null) { >> state = STOP; >> IOException e = new IOException(exception.toString()); >> e.initCause(exception); >> throw e; >> } >> >> Feature f = null; >> synchronized (this) { >> size--; >> f = features[head++]; >> notify(); >> >> >> if (head == features.length) { >> head = 0; >> } >> } >> return f; >> } >> >> --------------------------------------------------------------------- >> ---- >> This SF.net email is sponsored by: Splunk Inc. >> Still grepping through log files to find problems? Stop. >> Now Search log events and configuration files using AJAX and a >> browser. >> Download your FREE copy of Splunk now >> http://get.splunk.com/ >> _______________________________________________ >> Geotools-devel mailing list >> Geotools-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> > > > ---------------------------------------------------------------------- > --- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a > browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
