Simone Giannecchini a écrit :
> As per others successive emails, +1 on committing everything.
Thanks a lot!! I have yet an other suggestion in the process. I noticed the
following methods:
maskIndexColorModelByte
maskComponentColorModelByte
Looking at the code, it seems to me that "maskIndexColorModelByte" already works
with TYPE_USHORT in addition of TYPE_BYTE, so it seems appropriate to me to
rename it "maskIndexColorModel" without the "Byte" suffix...
I'm in the process of looking at "maskComponentColorModelByte", but from the
method name and signature I guess that it does the same than
"maskIndexColorModel", but applied on image with ComponentSampleModel rather
than IndexColorModel. If this is true, then I would like to turn the two above
methods into private ones (in which case the "assert" statements that you put
become perfectly legitimate), and put instead a single public method:
maskColor (or maye "makeColorTransparent" or something like that?)
which delegate automatically to one of the above method according the image
ColorModel, or thrown an exception if current implementation do not supports it
(but may supports in a future GeoTools version).
Would you agree?
Martin
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
