I am not sure I get it what are we trying to do with this change?

On 20/05/2010, at 9:40 PM, Heimo Laukkanen wrote:

> As a sidenote to the WMS module, could someone make following fix to
> the Extent class, unless it breaks something else.
> 
> public class Extent extends org.geotools.data.wms.xml.Extent {

Also which extent class are you wanting this change done to?
The reason I ask is no modules really depend on the wms module so they are not 
going to take kindly to extending org.geotools.data.wms.xml.Extent.

> 
>    public Extent(String name, String defaultValue, Boolean
> multipleValues, Boolean nearestValue, String value) {
>        super(name,defaultValue,multipleValues,nearestValue,value);
>    }
> 
>    public boolean isEmpty() {
>        return value == null || value.length() == 0;
>    }

Thanks :-)  Yeah code review.

> This makes 1.3.0 Dimension's extents work again. Atleast in the simple
> scenarios. We have now forked relevant classes to our own project and
> use this fixed Extent class.


------------------------------------------------------------------------------

_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to