On 20/05/2010, at 11:47 PM, Heimo Laukkanen wrote:

> On Thu, May 20, 2010 at 4:07 PM, Jody Garnett <jody.garn...@gmail.com> wrote:
>> I am not sure I get it what are we trying to do with this change?
> 
> There isn't a way to get the data ( extent ) from the dimension.

Okay we have two many things called extent - we better start using full package 
names as I cannot tell what is going on.
You are probably wanting an org.opengis Extent or an styling Extent or one of 
the ExtentImpl ?

> That happens because when we parse getCapabilitiesResponse and parser
> calls DimensionType's getValue, it passes handling extents to
> Extent.java AND includes extent to the dimension only if extent is not
> empty.
> 
> As current implementation of isEmpty is not compatible with the
> definition of empty, Dimension's extents are not put into the object
> graph -- even though they are in the xml and are otherwise parsed
> correctly.
> 
>> Also which extent class are you wanting this change done to?
>> The reason I ask is no modules really depend on the wms module so they are 
>> not going to take kindly to extending org.geotools.data.wms.xml.Extent.
> 
> org.geotools.data.wms.xml.Extent is the class where the problem is. We
> just extended geotools' Extent class in our project to fix this bug
> untill it is fixed in the upstream.

Sorry dude I am confused - the way you wrote it up did not make sense to me :-(
Can you submit an actual patch?

Jody
------------------------------------------------------------------------------

_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to