Okay let me try again ...

gt-wms 
======
org.geotools.data.wms.xml.Extent
-this is a class it does not implement any interfaces
- the isEmpty fix is applied here :-)
- this is the end of the line no modules depend on wms so nothing can extent 
org.geotools.data.wms.xml.Extent
- this class could implement an interface
- its job is to hold on to the section of the WMS 1.3 capabilities document
- this class get have a "toExtent()" method to convert the value to a useful 
implementation

org.opengis.metadata.extent.Extent
- this is an interface it is in a different project

org.geotools.metadata.iso.extent.ExtentImpl
- implementation of above metadata Extent

org.geotools.styling.Extent
- the documentation / specificaiton is so poor I cannot tell what the value is 
supposed to be

org.opengis.sld.Extent
- the slightly better document geopai version 

org.geotools.styling.ExtentImpl
- implementation of above styling Extent

Now what I would like returned is something useful such as a BoundingBox, or 
ReferencedEnvelope ... so I would recommend org.geotools.data.wms.xml.Extent 
get a toBounds() method returning a ReferencedEnvelope

Jody

On 20/05/2010, at 11:47 PM, Heimo Laukkanen wrote:

> On Thu, May 20, 2010 at 4:07 PM, Jody Garnett <jody.garn...@gmail.com> wrote:
>> I am not sure I get it what are we trying to do with this change?
> 
> Well at the moment, when you parse getCapabilities responses and have
> layers with dimensions and dimension extents, for example:
> 
> <wms:Layer>
> <wms:Name>hydro.runoffmaxaverage</wms:Name>
> <wms:Title>Average maximum runoff</wms:Title>
> <wms:CRS>EPSG:2393</wms:CRS>
> <wms:EX_GeographicBoundingBox>
> <wms:westBoundLongitude>19.872</wms:westBoundLongitude>
> <wms:eastBoundLongitude>33.030</wms:eastBoundLongitude>
> <wms:southBoundLatitude>59.769</wms:southBoundLatitude>
> <wms:northBoundLatitude>69.995</wms:northBoundLatitude>
> </wms:EX_GeographicBoundingBox>
> <wms:Dimension name="time" units="ISO8601">
>                    2025-01-01/2055-01-01/2085-01-01
> </wms:Dimension>
> <wms:Dimension name="emissionscenario" units="WHAT">
>                    SRES_A1FI,SRES_A2,SRES_B1,SRES_B2
> </wms:Dimension>
> </wms:Layer>
> 
> There isn't a way to get the data ( extent ) from the dimension.
> 
> That happens because when we parse getCapabilitiesResponse and parser
> calls DimensionType's getValue, it passes handling extents to
> Extent.java AND includes extent to the dimension only if extent is not
> empty.
> 
> As current implementation of isEmpty is not compatible with the
> definition of empty, Dimension's extents are not put into the object
> graph -- even though they are in the xml and are otherwise parsed
> correctly.
> 
>> Also which extent class are you wanting this change done to?
>> The reason I ask is no modules really depend on the wms module so they are 
>> not going to take kindly to extending org.geotools.data.wms.xml.Extent.
> 
> org.geotools.data.wms.xml.Extent is the class where the problem is. We
> just extended geotools' Extent class in our project to fix this bug
> untill it is fixed in the upstream.
> 
> -huima

------------------------------------------------------------------------------

_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to