That is fine Andrea; it is a long weekend here so if you can review Sunday I think that gives me time to commit. I mostly want to have the api changes in place when I do a run of the workshop materials next week. On the plus side I will have a patch ready for you by then.
Aside: there is also the screen map patch for renderer floating around; I don't think the two will conflict as they are at different parts of the renderer Jody On 08/06/2010, at 5:28 PM, Andrea Aime wrote: > Jody Garnett wrote: >> Proposal is established enough to be voted on; I will be working on this >> over several evenings this week with this weekend targeted for the first >> commit. >> - http://docs.codehaus.org/display/GEOTOOLS/MapContext+Refactor >> - http://jira.codehaus.org/browse/GEOT-3136 (Initial patch showing the api; >> used to produce diagrams above) >> Summary: >> MapContext and MapLayer have really grown over time - and in some cases have >> diverged from their actual use. >> Summary: >> • MapContext use replaced by the class Map (for stability and so we >> don't have two java files) >> • MapContext itself will gain a toMap() method which can be used by the >> renderer to handle code during the transition >> • Map uses layers() method to provide direct access to the layer list; >> removing 50% of the methods from MapContext >> • Map has improved "viewport" methods (MapContext viewport model >> methods are not currently used in the codebase - in part because they are so >> confusing) >> • MapLayer replaced by Layer class >> • Specific Layer subclasses for different kinds of content; this is an >> open ended set allowing additional kinds of layers to be added over time for >> TileServers, Google Maps and so forth >> • DefaultMapLayer re-factored to use an internal Layer delegate (so >> existing code will not be broken; and importantly will not be duplicated) >> • DefaultMapLayer toLayer() method used by the renderer during the >> transition >> This proposal does not break any existing API; it provides a safe migration >> path forward (and like the Query proposal) makes use of classes directly for >> a simplified experience. > > I will not have time to review this one up until Sunday, can you avoid > commits for a few days? > > Cheers > Andrea ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
