Took quick look at the proposal, I am +0. MIght turn into +1 once I have played with the enhancements.
Simone. ------------------------------------------------------- Ing. Simone Giannecchini GeoSolutions S.A.S. Founder - Software Engineer Via Carignoni 51 55041 Camaiore (LU) Italy phone: +39 0584983027 fax: +39 0584983027 mob: +39 333 8128928 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.linkedin.com/in/simonegiannecchini http://twitter.com/simogeo ------------------------------------------------------- On Wed, Jun 9, 2010 at 4:37 PM, Jody Garnett <[email protected]> wrote: > A second patch is now available: > - http://jira.codehaus.org/browse/GEOT-3136 > > This patch is complete; with DefaultMapLayer using an internal Layer (tested > with Quickstart and ImageLab to confirm functionality). > Ben I notice you have a FeatureSourceMapLayer - I don't think this is needed > after the refactor; but I have no good way of testing. > > Work remaining: > - Test WMSMapLayer tomorrow > - Map vs MapContext > - Update Renderer code to use Layer directly > > Jody > > On 08/06/2010, at 10:15 AM, Jody Garnett wrote: > >> Proposal is established enough to be voted on; I will be working on this >> over several evenings this week with this weekend targeted for the first >> commit. >> - http://docs.codehaus.org/display/GEOTOOLS/MapContext+Refactor >> - http://jira.codehaus.org/browse/GEOT-3136 (Initial patch showing the api; >> used to produce diagrams above) >> >> Summary: >> >> MapContext and MapLayer have really grown over time - and in some cases have >> diverged from their actual use. >> >> Summary: >> • MapContext use replaced by the class Map (for stability and so we >> don't have two java files) >> • MapContext itself will gain a toMap() method which can be used by >> the renderer to handle code during the transition >> • Map uses layers() method to provide direct access to the layer list; >> removing 50% of the methods from MapContext >> • Map has improved "viewport" methods (MapContext viewport model >> methods are not currently used in the codebase - in part because they are so >> confusing) >> • MapLayer replaced by Layer class >> • Specific Layer subclasses for different kinds of content; this is an >> open ended set allowing additional kinds of layers to be added over time for >> TileServers, Google Maps and so forth >> • DefaultMapLayer re-factored to use an internal Layer delegate (so >> existing code will not be broken; and importantly will not be duplicated) >> • DefaultMapLayer toLayer() method used by the renderer during the >> transition >> >> This proposal does not break any existing API; it provides a safe migration >> path forward (and like the Query proposal) makes use of classes directly for >> a simplified experience. > > > ------------------------------------------------------------------------------ > ThinkGeek and WIRED's GeekDad team up for the Ultimate > GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the > lucky parental unit. See the prize list and enter to win: > http://p.sf.net/sfu/thinkgeek-promo > _______________________________________________ > Geotools-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > ------------------------------------------------------------------------------ ThinkGeek and WIRED's GeekDad team up for the Ultimate GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the lucky parental unit. See the prize list and enter to win: http://p.sf.net/sfu/thinkgeek-promo _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
