On Sat, Nov 3, 2012 at 7:27 PM, Justin Deoliveira <jdeol...@opengeo.org> wrote: >> SecuredFeatureCollection wise I believe we can just drop all the extra >> methods >> Jody removed from FeatureCollection, >> don't think that GeoServer uses any of them but wanted to make sure >> security >> could not be broken by accident if one module started using them > > Yeah, more or less that is what i did. There was a test case though that > were calling the remove/add methods, so updated that. Will definitely want a > review on that stuff.
Sure will do. Since it was security I wanted to make sure I was shutting down all possible ways to write when not allowed (well, past reflection against private fields of course), but those methods and the tests were just me being thorough as I believe there is nothing in GeoServer using them. I'll have a look at the branch as it's made available. Cheers Andrea >> >> >> Cheers >> Andrea >> >> -- >> == >> Our support, Your Success! Visit http://opensdi.geo-solutions.it for >> more information. >> == >> >> Ing. Andrea Aime >> @geowolf >> Technical Lead >> >> GeoSolutions S.A.S. >> Via Poggio alle Viti 1187 >> 55054 Massarosa (LU) >> Italy >> phone: +39 0584 962313 >> fax: +39 0584 1660272 >> mob: +39 339 8844549 >> >> http://www.geo-solutions.it >> http://twitter.com/geosolutions_it >> >> ------------------------------------------------------- > > > > > -- > Justin Deoliveira > OpenGeo - http://opengeo.org > Enterprise support for open source geospatial. > -- == Our support, Your Success! Visit http://opensdi.geo-solutions.it for more information. == Ing. Andrea Aime @geowolf Technical Lead GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584 962313 fax: +39 0584 1660272 mob: +39 339 8844549 http://www.geo-solutions.it http://twitter.com/geosolutions_it ------------------------------------------------------- ------------------------------------------------------------------------------ LogMeIn Central: Instant, anywhere, Remote PC access and management. Stay in control, update software, and manage PCs from one command center Diagnose problems and improve visibility into emerging IT issues Automate, monitor and manage. Do more in less time with Central http://p.sf.net/sfu/logmein12331_d2d _______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
