Everything looks in order (I think we should remove sections of our proposal
template that do not get filled in).
Going through the patch I see things like DirectoryDataStore delegating to
getDataStore(name).removeSchema(name). Does that indicate the associated shape
file (or property file?) will be removed? Checking JDBCDataStore implementation
and API javadocs .. yes.
Checking ContentDataStore I see the method is not implemented; so shape file
datastore will just error out.
So this is a case where we are taking on technical debt; this is why we have
the tasks section so we can see what work is needed and make sure it is coved.
So no problem with the pull request; but we should create a bug report for the
new technical debt.
--
Jody Garnett
On 4 November 2013 at 9:39:50 pm, Daniele Romagnoli
([email protected]) wrote:
Hi guys,
I have worked on GEOT-2333 [1], by integrating the available patches and by
updating some other datastore classes.
That JIRA was dealing with the already voted remove Schema proposal [2].
The pull request is available at [3].
Do you have any feedbacks on that?
Cheers,
Daniele
[1]: http://jira.codehaus.org/browse/GEOT-2333
[2]:
http://docs.codehaus.org/display/GEOTOOLS/Add+ability+to+remove+feature+types
[3]: https://github.com/geotools/geotools/pull/308
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Daniele Romagnoli
Senior Software Engineer
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
------------------------------------------------------------------------------
Android is increasing in popularity, but the open development platform that
developers love is also attractive to malware creators. Download this white
paper to learn more about secure code signing practices that can help keep
Android apps secure.
http://pubads.g.doubleclick.net/gampad/clk?id=65839951&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
