On Mon, Nov 4, 2013 at 11:38 AM, Daniele Romagnoli <
[email protected]> wrote:

> Hi guys,
> I have worked on GEOT-2333 [1], by integrating the available patches and
> by updating some other datastore classes.
> That JIRA was dealing with the already voted remove Schema proposal [2].
>
> The pull request is available at [3].
> Do you have any feedbacks on that?
>

Had a look, generally speaking it looks good, however it breaks the build
with a compile error in the
pre-generalized store:

[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.1:compile
(default-compile) on project gt-feature-pregeneralized: Compilation failure
[ERROR]
/home/aaime/devel/git-gt/modules/plugin/feature-pregeneralized/src/main/java/org/geotools/data/gen/PreGeneralizedDataStore.java:[71,7]
org.geotools.data.gen.PreGeneralizedDataStore is not abstract and does not
override abstract method removeSchema(java.lang.String) in
org.geotools.data.DataStore

The build has to pass fully before the pull request gets merged

Cheers
Andrea

-- 
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

-------------------------------------------------------
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most 
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to