On Mon, Nov 4, 2013 at 12:56 PM, Jody Garnett <[email protected]>wrote:
> Everything looks in order (I think we should remove sections of our
> proposal template that do not get filled in).
>
> Going through the patch I see things like DirectoryDataStore delegating to
> getDataStore(name).removeSchema(name). Does that indicate the associated
> shape file (or property file?) will be removed? Checking JDBCDataStore
> implementation and API javadocs .. yes.
>
> Checking ContentDataStore I see the method is not implemented; so shape
> file datastore will just error out.
>
> So this is a case where we are taking on technical debt; this is why we
> have the tasks section so we can see what work is needed and make sure it
> is coved.
>
Why do you call it technical debt? It's an optional feature that is not
being implemented where it could, but it's not making the code
more cluttered, or using more deprecated methods.
The directory store has no ownership of the data it deals with, and
delegates to stores that might or might not implement
this optional feature. The caller is warned, dropSchema might not be
implemented, even for directory store, not sure
why it should get any special treatment.
Cheers
Andrea
--
==
Our support, Your Success! Visit http://opensdi.geo-solutions.it for more
information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
