On Sun, Mar 15, 2015 at 7:43 PM, Ben Caradoc-Davies <[email protected]>
wrote:
> I have not seen an app-schema failure for a couple of months. I am happy
> to advise Torben and Jody on setting up app-schema online tests (see link
> on the GS list); I think Jody has already suggested that Boundless may be
> able to help.
>
> The main problem is in my view the one you have already identified:
> submitters not running tests. And Travis being broken and ignored. And
> GeoTools developers not building GeoServer after changing GeoTools.
>
> If you really want to crack the whip, could we get more PMC/PSC members
> testing pull request with full GT+GS builds? This is what I do before
> merging a pull request (so far one this year), if I have the slightest
> concern (and I am a regular worry-wort). The real reason this does not
> happen is because *you* are pretty much the *only one* reviewing pull
> requests and there are not enough hours in the day for you to run so many
> builds yourself. You do too much already. A better effort on pull requests
> from other PMC/PSC members would increase quality. It all comes down to
> available developer time. If Travis were fixed, this would I am sure be a
> huge help.
>
>
Sooo... had a lonely lunch, and thus time to think a bit more. A few
observations:
* GeoTools is a stand alone project, demanding people that are not
interested in GeoServer to also build GeoServer is wrong, if a commit
breaks the GeoServer build instead of the GeoTools one it means we don't
have enough test coverage in GeoTools, and when that happens, the
maintainer of the geotools module causing the failure in the GeoServer
build should take note and add coverage as necessary
* Running the builds is basically wasted time for anyone doing the reviews,
not just me, we should find a way to automate that if at all possible.
Fixing the build for Travis is relatively easy (don't think the world will
cry wolf because gt-ogr-bridj is not built with tests, doubt many people
are using it), but getting an hint of whether a pull request will make the
GeoServer build fail is valuable, but apparently hard (ideas welcomed)
* Of course, help reviewing the pull requests is more than welcomed... but
I doubt we'll get much traction if we require the reviews to run all the
builds manually, quoting from a comment of yours on the type cache pull
request, when I asked where were you in the 30 days the pull request had
been open, you answered "@aaime you know that I am too lazy to take notice
until my beloved unit tests start failing. ;-)" I know you were joking,
but there's a good portion of truth in that joke, and it does not apply to
you only.
And in the end you're indeed right, I don't do the builds anymore when
reviewing the pull requests because it takes too much time, a visual code
inspection of the diff is all I manage to put in, and it's clearly not
enough.
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Dive into the World of Parallel Programming The Go Parallel Website, sponsored
by Intel and developed in partnership with Slashdot Media, is your hub for all
things parallel software development, from weekly thought leadership blogs to
news, videos, case studies, tutorials and more. Take a look and join the
conversation now. http://goparallel.sourceforge.net/
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
