On 16/03/15 08:55, Andrea Aime wrote: > * GeoTools is a stand alone project, demanding people that are not > interested in GeoServer to also build GeoServer is wrong
But projects that care about their users should at least keep an eye on known downstream builds and fix failures with alacrity. Especially when the developer is on the committees of both projects. And especially especially when tampering with ContentDataStore. > Fixing the build for Travis is relatively easy (don't think the world will > cry wolf because gt-ogr-bridj is not built with tests, doubt many people > are using it) It looks like Travis is using Ubuntu 12.04.5 LTS and is affected by the same bug as on Debian wheezy (see Jira for my workaround): https://jira.codehaus.org/browse/GEOT-4733 > And in the end you're indeed right, I don't do the builds anymore when > reviewing the pull requests because it takes too much time, a visual code > inspection of the diff is all I manage to put in, and it's clearly not > enough. If developers take more care and build their code and major known downstreams before submitting pull requests, you can continue to provide valuable high-level review and rely on Jenkins to pick up platform and project interactions that are not caught by local builds. This is likely a much better use of your time. Unfortunately, the standard of pull requests is not always good. I have seen a recent pull request from a PMC member that did not even compile in Maven because it had a badly-formed pom; this was discovered *after* it was merged by that same PMC member. Accidents happen, but the error rate is in my view increasing, and this should be a warning to us all. <soapbox>I call on all contributors to improve the quality of their commits and pull requests.</soapbox> Kind regards, -- Ben Caradoc-Davies <[email protected]> Software Engineer Transient Software <http://transient.nz> New Zealand ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
