Hi Nicolai,
I've tested out builds with JDK 8 of GeoTools, GeoWebCache and GeoServer
with your
pull request applied, all good besides the trivial changes you mentioned.
So, nice, it won't break our stream of development.
Looking at the pull request I have found it introduces deprecations without
cleaning up usage,
I really don't want to see more deprecation warnings in the codebase, could
you please clean
up the usage points as well and document in the javadoc how a deprecated
method should be
replaced?
As mentioned in the pull request, that might make you either reconsider
deprecation, or consider
writing some new replacement methods (if you find yourself writing the same
bits of code over and over).
About building on Java 9 instead... that's a non starter, as far as I can
see imageio-ext won't even start building
due to its JAXB usage in a core package... I suppose that's easily
replaceable.
There are also annoying log messages that will require a imageio fork
(well, repackaging with, I hope,
a single one liner change in a SPI registration file), see last comment at:
https://github.com/geosolutions-it/jai-ext/issues/161
I've tried anyways to build GeoTools with JDK 9 and it's failing right out
of the bat in the cross module javadoc...
meh, honestly, do we really need it (and the other custom plugins, save
maybe the javacc one?).
Then tried to skip it, and we have failures in the main modul
(SLDTransformerTest, looks like there
is a different behavior in XML generation and space preservation).
I stopped there.
Anyhow, +1 on the proposal and on merging (once the deprecation feedback
above is addressed), looks like
a step in the right direction, even if more work is needed to actually
build on JDK 9 our full project chain.
Oh... did anyone make interactive tests? (I did not).
Cheers
Andrea
On Thu, Oct 5, 2017 at 9:50 AM, Andrea Aime <[email protected]>
wrote:
> Hi Nicolai,
> yes, please prepare that pull request, I'm going to investigate a bit
> during the weekend (making sure a full build actually works
> after all the pull requests are merged)
>
> Cheers
> Andrea
>
>
> On Wed, Oct 4, 2017 at 8:21 PM, Nicolai Parlog <[email protected]> wrote:
>
>> Hi Andrea,
>>
>> thanks for your feedback and for pointing out those projects - I
>> didn't know about them. I did a quick search [1, 2] and only found
>> these two lines of code:
>>
>> [3]: Iterator<DXFWriter> it = writerRegistry
>> .getServiceProviders(DXFWriter.class, null, null);
>>
>> [4]: Iterator i = FactoryRegistry
>> .lookupProviders(extensionPoint);
>>
>> Both are very easy to update. If these are all, I will include them in
>> the proposal section on "API before/after" and prepare a PR that can
>> be merged immediately after #1670 is merged.
>>
>> so long ... Nicolai
>>
>>
>> [1]:
>> https://github.com/GeoWebCache/geowebcache/search?utf8=%E2%
>> 9C%93&q=FactoryRegistry&type=
>> [2]:
>> https://github.com/geoserver/geoserver/search?utf8=%E2%9C%93
>> &q=FactoryRegistry&type=
>> [3]:
>> https://github.com/geoserver/geoserver/blob/55c4740060eb2b88
>> 09ae935a510ac83eeb923313/src/extension/dxf/core/src/main/
>> java/org/geoserver/wfs/response/dxf/DXFWriterFinder.java#L58
>> [4]:
>> https://github.com/geoserver/geoserver/blob/55c4740060eb2b88
>> 09ae935a510ac83eeb923313/src/platform/src/main/java/org/
>> geoserver/platform/GeoServerExtensions.java#L166
>>
>>
>>
>> On 04.10.2017 10:19, Andrea Aime wrote:
>> > Hi Jody, I don't see a section talking about the directly affected
>> > downstream projects.
>> >
>> > GeoWebCache and GeoServer build off the GeoTools snapshots
>> > directly, so the moment the pull request land they will be hit
>> > immediately, if that breaks the build, development will stop on
>> > both until we get the build back.
>> >
>> > So I would like to see some section talking about that, if tests
>> > have been made, and in case of failure, what resources have been
>> > allocated to handle the switch. Doing so we could also learn things
>> > that might need changing in the proposal to make the switch less
>> > painful for other downstream projects.
>> >
>> > Other downstream projects will eventually be affected, like
>> > GeoMesa, GeoWave, GeoTrellis (and uDig too, the day that it manages
>> > to realign itself with GeoTools), not right out of the box I
>> > believe (unless they also depend on snapshots, I'm not sure), so
>> > having a migration guide in the mix would be good too.
>> >
>> > I'm happy to provide some help during weekends.
>> >
>> > Cheers Andrea
>> >
>> > On Tue, Oct 3, 2017 at 11:31 PM, Jody Garnett
>> > <[email protected]> wrote:
>> >
>> >> As a follow up to today's meeting, please consider and vote on
>> >> the following proposal:
>> >>
>> >> https://github.com/geotools/geotools/wiki/FactoryRegistry-
>> >> Refactoring-for-Java-9-Compatibility
>> >>
>> >>
>> >> -- Jody Garnett
>> >>
>> >> ------------------------------------------------------------
>> >> ------------------ Check out the vibrant tech community on one of
>> >> the world's most engaging tech sites, Slashdot.org!
>> >> http://sdm.link/slashdot
>> >> _______________________________________________ GeoTools-Devel
>> >> mailing list [email protected]
>> >> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>> >>
>> >>
>> >
>> >
>> >
>> >
>> > ------------------------------------------------------------
>> ------------------
>> >
>> >
>> Check out the vibrant tech community on one of the world's most
>> > engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> >
>> >
>> >
>> > _______________________________________________ GeoTools-Devel
>> > mailing list [email protected]
>> > https://lists.sourceforge.net/lists/listinfo/geotools-devel
>> >
>>
>> --
>>
>> PGP Key:
>> http://keys.gnupg.net/pks/lookup?op=vindex&search=0xCA3BAD2E9CCCD509
>>
>> Web:
>> http://codefx.org
>> a blog about software development
>> https://www.sitepoint.com/java
>> high-quality Java/JVM content
>> http://do-foss.de
>> Free and Open Source Software for the City of Dortmund
>>
>> Twitter:
>> https://twitter.com/nipafx
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> GeoTools-Devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>
>
>
> --
>
> Regards,
>
> Andrea Aime
>
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054 Massarosa (LU)
> phone: +39 0584 962313 <+39%200584%20962313>
> fax: +39 0584 1660272 <+39%200584%20166%200272>
> mob: +39 339 8844549 <+39%20339%20884%204549>
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
>
--
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
