I tried to capture how downsteam applications are effected by adding a
factory finders example showing no change. I do not know how much the GWC
and GeoServer codebase make use of FactoryRegistery directly; or if they
use FatoryFinder (as recommended in the GeoTools user guide).
There are four ways in which a downstream application can interact with
GeoTools:
1) FactoryFinder - recommended technique and unaffected by this change
2) FactoryRegistry - used internally by FactoryFinder, it is a public class
so downstream applications can use it. If so they will need to change
methods that say "service" into methods that say "factory" (as covered in
the API section of the proposal)
3) Implementing a GeoTools Factory - I do not see any breakage here, this
proposal still makes use of GeoTools Hints (which extend Rendering Hints).
We could argue that extending Java Hints is not the best plan (it was a
limitation imposed on us by reuse of ServiceRegistry). If we would like to
change this part of the GeoTools Factory interface now would be a good
time; and we could include it as part of the proposal. (I think I would
still do it as a second task as the pull request as written runs with
minimal discussion).
--
Jody Garnett
On 4 October 2017 at 01:19, Andrea Aime <[email protected]>
wrote:
> Hi Jody,
> I don't see a section talking about the directly affected downstream
> projects.
>
> GeoWebCache and GeoServer build off the GeoTools snapshots directly, so
> the moment
> the pull request land they will be hit immediately, if that breaks the
> build, development
> will stop on both until we get the build back.
>
> So I would like to see some section talking about that, if tests have been
> made,
> and in case of failure, what resources have been allocated to handle the
> switch.
> Doing so we could also learn things that might need changing in the
> proposal to
> make the switch less painful for other downstream projects.
>
> Other downstream projects will eventually be affected, like GeoMesa,
> GeoWave,
> GeoTrellis (and uDig too, the day that it manages to realign itself with
> GeoTools),
> not right out of the box I believe (unless they also depend on snapshots,
> I'm
> not sure), so having a migration guide in the mix would be good too.
>
> I'm happy to provide some help during weekends.
>
> Cheers
> Andrea
>
> On Tue, Oct 3, 2017 at 11:31 PM, Jody Garnett <[email protected]>
> wrote:
>
>> As a follow up to today's meeting, please consider and vote on the
>> following proposal:
>>
>> https://github.com/geotools/geotools/wiki/FactoryRegistry-Re
>> factoring-for-Java-9-Compatibility
>>
>>
>> --
>> Jody Garnett
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> GeoTools-Devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
>
>
> --
>
> Regards,
>
> Andrea Aime
>
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%A0Massarosa&entry=gmail&source=g>
> 55054 Massarosa
> <https://maps.google.com/?q=Via+di+Montramito+3/A+55054+%C2%A0Massarosa&entry=gmail&source=g>
> (LU)
> phone: +39 0584 962313 <+39%200584%20962313>
> fax: +39 0584 1660272 <+39%200584%20166%200272>
> mob: +39 339 8844549 <+39%20339%20884%204549>
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
