Hi Cesar,
our rule of thumb is "one commit per pull request", mostly to allow easy
backporting, but also because
some (me for example) don't care to see how you got to the final result,
and find distracting going over
the many commits.
Given this will not be backported and multiple people have worked on it
already, I guess it's ok to merge
master, the history cannot be really be polluted more than it is already :-p
Cheers
Andrea
On Thu, Apr 5, 2018 at 7:21 PM, César Martínez Izquierdo <
cesar....@gmail.com> wrote:
> Hi Andrea,
>
> You are right, the branch was created around March 21th, so changes
> done after that date are missing.
> I've now tested that Geoserver fully compiles when compiled against a
> test_units_jsr363 branch which includes latest Geotools master
> changes.
> Should I merge Geotools master in the test_units_jsr363 branch, or
> will this pollute history?
>
> Regards.
>
> On 5 April 2018 at 18:28, Andrea Aime <andrea.a...@geo-solutions.it>
> wrote:
> > Hi Cesar,
> > probably your GeoTools branch is out of date, there is a new
> > copyNamespaceSupport method that
> > has been added March 21th
> >
> > Cheers
> > Andrea
> >
> > On Thu, Apr 5, 2018 at 6:17 PM, César Martínez Izquierdo
> > <cesar....@gmail.com> wrote:
> >>
> >> Hi again,
> >>
> >> Geoserver is properly compiling and passing tests now in the branch,
> >> using:
> >> mvn -fn clean install
> >>
> >> There is only one compilation error in the wfs module which seems to
> >> be unrelated with the JSR migration (PropertyNameTypeBinding is
> >> expecting a method in GML3EncodingUtils which does not exist). So it
> >> seems we are coming closer to completing the migration.
> >>
> >> César
> >>
> >> On 5 April 2018 at 17:01, César Martínez Izquierdo <cesar....@gmail.com
> >
> >> wrote:
> >> > Hi, I've created a branch for working on Geoserver adaptation:
> >> > https://github.com/dispiste/geoserver/tree/jsr363_units
> >> >
> >> > I've also created a PR to allow collaboration:
> >> > https://github.com/geoserver/geoserver/pull/2828
> >> >
> >> > Best regards,
> >> >
> >> > César
> >> >
> >> > On 5 April 2018 at 10:17, Jody Garnett <jody.garn...@gmail.com>
> wrote:
> >> >> I understand, the high number of files is due a series of search and
> >> >> replaces (as outlined in the proposal). If it helps I have a few key
> >> >> "huh"
> >> >> areas where I would like your experienced viewpoint (since your name
> is
> >> >> on
> >> >> the EPSG and ESRI unit formatters). I will go back and start a
> >> >> conversation
> >> >> on those points.
> >> >>
> >> >> Still I am happy enough with these changes to start a branch on GWC
> and
> >> >> GeoServer.
> >> >>
> >> >> --
> >> >> Jody Garnett
> >> >>
> >> >> On 5 April 2018 at 00:17, Andrea Aime <andrea.a...@geo-solutions.it>
> >> >> wrote:
> >> >>>
> >> >>> Hi Jody,
> >> >>> whoa this is massive, 229 files changed?
> >> >>> I won't be able to look at it soon, next week I'm in the US and
> >> >>> travelling
> >> >>> there during the weekend, next weekend I'll probably be wiped and
> get
> >> >>> some
> >> >>> rest.
> >> >>>
> >> >>> Cheers
> >> >>> Andrea
> >> >>>
> >> >>>
> >> >>> On Thu, Apr 5, 2018 at 8:40 AM, Jody Garnett <
> jody.garn...@gmail.com>
> >> >>> wrote:
> >> >>>>
> >> >>>> And now some days later, the pull request passes tests and is ready
> >> >>>> for
> >> >>>> review:
> >> >>>>
> >> >>>> - https://github.com/geotools/geotools/pull/1834
> >> >>>>
> >> >>>> I have continued to update the proposal with notes about any api
> >> >>>> changes
> >> >>>> (especially bulk search and replace).
> >> >>>>
> >> >>>> --
> >> >>>> Jody Garnett
> >> >>>>
> >> >>>> On 26 March 2018 at 22:04, Jody Garnett <jody.garn...@gmail.com>
> >> >>>> wrote:
> >> >>>>>
> >> >>>>> The proposal page
> >> >>>>> (https://github.com/geotools/geotools/wiki/Migrate-Units-
> to-JSR-363)
> >> >>>>> has
> >> >>>>> been updated over the course of the sprint.
> >> >>>>>
> >> >>>>> The PR (https://github.com/geotools/geotools/pull/1834) is not
> quite
> >> >>>>> ready yet :(
> >> >>>>>
> >> >>>>> Cesar and myself traded of migration tasks over the course of the
> >> >>>>> week:
> >> >>>>>
> >> >>>>> We found the land scape of implementations to be complicated by
> two
> >> >>>>> things:
> >> >>>>>
> >> >>>>> 1) There component has both a standard implementation and a
> >> >>>>> reference
> >> >>>>> implementation . The reference implementation was done in floats
> as
> >> >>>>> a toy,
> >> >>>>> and of course put into production for mobile.
> >> >>>>>
> >> >>>>> 2) Each jar has both a normal implementation, and a java8
> >> >>>>> implementation
> >> >>>>> - I presume in response to jigsaw
> >> >>>>>
> >> >>>>> Currently I am stuck on a gap in JSR 363:
> >> >>>>>
> >> >>>>> * Measure<V,Q extends Quantity>, we make use of DecimalMeasure and
> >> >>>>> VectorMeasure in the gt-coverage module.
> >> >>>>>
> >> >>>>> There is some discussion here:
> >> >>>>> https://github.com/unitsofmeasurement/unit-ri/issues/61
> >> >>>>>
> >> >>>>> A way forward to to add to our org.geotools.util, or
> >> >>>>> org.geotools.measure class to define similar constructs. However I
> >> >>>>> am not
> >> >>>>> sure how valuable these abstractions are.
> >> >>>>> --
> >> >>>>> Jody Garnett
> >> >>>>
> >> >>>>
> >> >>>>
> >> >>>>
> >> >>>>
> >> >>>> ------------------------------------------------------------
> ------------------
> >> >>>> Check out the vibrant tech community on one of the world's most
> >> >>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> >> >>>> _______________________________________________
> >> >>>> GeoTools-Devel mailing list
> >> >>>> GeoTools-Devel@lists.sourceforge.net
> >> >>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
> >> >>>>
> >> >>>
> >> >>>
> >> >>>
> >> >>> --
> >> >>>
> >> >>> Regards,
> >> >>>
> >> >>> Andrea Aime
> >> >>>
> >> >>> ==
> >> >>> GeoServer Professional Services from the experts! Visit
> >> >>> http://goo.gl/it488V for more information.
> >> >>> ==
> >> >>>
> >> >>> Ing. Andrea Aime
> >> >>> @geowolf
> >> >>> Technical Lead
> >> >>>
> >> >>> GeoSolutions S.A.S.
> >> >>> Via di Montramito 3/A
> >> >>> 55054 Massarosa (LU)
> >> >>> phone: +39 0584 962313
> >> >>> fax: +39 0584 1660272
> >> >>> mob: +39 339 8844549
> >> >>>
> >> >>> http://www.geo-solutions.it
> >> >>> http://twitter.com/geosolutions_it
> >> >>>
> >> >>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
> >> >>>
> >> >>> Le informazioni contenute in questo messaggio di posta elettronica
> e/o
> >> >>> nel/i file/s allegato/i sono da considerarsi strettamente riservate.
> >> >>> Il loro
> >> >>> utilizzo è consentito esclusivamente al destinatario del messaggio,
> >> >>> per le
> >> >>> finalità indicate nel messaggio stesso. Qualora riceviate questo
> >> >>> messaggio
> >> >>> senza esserne il destinatario, Vi preghiamo cortesemente di darcene
> >> >>> notizia
> >> >>> via e-mail e di procedere alla distruzione del messaggio stesso,
> >> >>> cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> >> >>> divulgarlo
> >> >>> anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> >> >>> utilizzarlo per
> >> >>> finalità diverse, costituisce comportamento contrario ai principi
> >> >>> dettati
> >> >>> dal D.Lgs. 196/2003.
> >> >>>
> >> >>> The information in this message and/or attachments, is intended
> solely
> >> >>> for
> >> >>> the attention and use of the named addressee(s) and may be
> >> >>> confidential or
> >> >>> proprietary in nature or covered by the provisions of privacy act
> >> >>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data
> >> >>> Protection
> >> >>> Code).Any use not in accord with its purpose, any disclosure,
> >> >>> reproduction,
> >> >>> copying, distribution, or either dissemination, either whole or
> >> >>> partial, is
> >> >>> strictly forbidden except previous formal approval of the named
> >> >>> addressee(s). If you are not the intended recipient, please contact
> >> >>> immediately the sender by telephone, fax or e-mail and delete the
> >> >>> information in this message that has been received in error. The
> >> >>> sender does
> >> >>> not give any warranty or accept liability as the content, accuracy
> or
> >> >>> completeness of sent messages and accepts no responsibility for
> >> >>> changes
> >> >>> made after they were sent or for other risks which arise as a result
> >> >>> of
> >> >>> e-mail transmission, viruses, etc.
> >> >>>
> >> >>>
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> >> > César Martínez Izquierdo
> >> > GIS developer
> >> > - - - - - - - - - - - - - - - - - - - -
> >> > SCOLAB: http://www.scolab.es
> >> > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> >>
> >>
> >>
> >> --
> >> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> >> César Martínez Izquierdo
> >> GIS developer
> >> - - - - - - - - - - - - - - - - - - - -
> >> SCOLAB: http://www.scolab.es
> >> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> >
> >
> >
> >
> > --
> >
> > Regards,
> >
> > Andrea Aime
> >
> > ==
> > GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V
> > for more information.
> > ==
> >
> > Ing. Andrea Aime
> > @geowolf
> > Technical Lead
> >
> > GeoSolutions S.A.S.
> > Via di Montramito 3/A
> > 55054 Massarosa (LU)
> > phone: +39 0584 962313
> > fax: +39 0584 1660272
> > mob: +39 339 8844549
> >
> > http://www.geo-solutions.it
> > http://twitter.com/geosolutions_it
> >
> > AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
> >
> > Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i
> > file/s allegato/i sono da considerarsi strettamente riservate. Il loro
> > utilizzo è consentito esclusivamente al destinatario del messaggio, per
> le
> > finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio
> > senza esserne il destinatario, Vi preghiamo cortesemente di darcene
> notizia
> > via e-mail e di procedere alla distruzione del messaggio stesso,
> > cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo
> > anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo
> per
> > finalità diverse, costituisce comportamento contrario ai principi dettati
> > dal D.Lgs. 196/2003.
> >
> > The information in this message and/or attachments, is intended solely
> for
> > the attention and use of the named addressee(s) and may be confidential
> or
> > proprietary in nature or covered by the provisions of privacy act
> > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> > Code).Any use not in accord with its purpose, any disclosure,
> reproduction,
> > copying, distribution, or either dissemination, either whole or partial,
> is
> > strictly forbidden except previous formal approval of the named
> > addressee(s). If you are not the intended recipient, please contact
> > immediately the sender by telephone, fax or e-mail and delete the
> > information in this message that has been received in error. The sender
> does
> > not give any warranty or accept liability as the content, accuracy or
> > completeness of sent messages and accepts no responsibility for changes
> > made after they were sent or for other risks which arise as a result of
> > e-mail transmission, viruses, etc.
> >
> >
>
>
>
> --
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
> César Martínez Izquierdo
> GIS developer
> - - - - - - - - - - - - - - - - - - - -
> SCOLAB: http://www.scolab.es
> - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
>
--
Regards,
Andrea Aime
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
