Patch Set 2: (1 comment)
What about naming it "public_iface" rather than "eth_iface"? Then we have public_iface vs lo_iface or private_iface. Instead of "public_iface" at some point (msc+bsc split) we may want to have "uplink_iface" and "downlink_iface" (which could be set to the same OS iface/ip). https://gerrit.osmocom.org/#/c/2681/2/src/osmo_gsm_tester/resource.py File src/osmo_gsm_tester/resource.py: Line 44: R_NITB_IFACE = 'eth_iface' missing change here. (NITB). You may want to run grep with CAPS enabled. -- To view, visit https://gerrit.osmocom.org/2681 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I829903d7b2111ab5ee106bce52d6121204a5a401 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
