Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/2681/2/src/osmo_gsm_tester/osmo_nitb.py File src/osmo_gsm_tester/osmo_nitb.py: Line 29: eth_iface = None > The rename to eth_iface makes sense on the resource level, but the NITB and AFAIU it should still be possible for the BSC to bind to several ifaces/ips right? like one downlink (towards BTSs) and one uplink (towards the MSC). I guess it would make sense to call them like: lo_iface, ctrl_iface, downlink_iface, uplink_iface, etc. -- To view, visit https://gerrit.osmocom.org/2681 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I829903d7b2111ab5ee106bce52d6121204a5a401 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-HasComments: Yes
