Patch Set 2: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/2681/2/src/osmo_gsm_tester/osmo_nitb.py File src/osmo_gsm_tester/osmo_nitb.py: Line 29: eth_iface = None The rename to eth_iface makes sense on the resource level, but the NITB and other programs should be agnostic of whether it is a public eth interface address or a loopback interface address. So this should have a more general name. Also it should probably reflect that it's the addr the NITB wants to bind on: bind_addr? Also see addr(); maybe make them bind_addr() and self._bind_addr? -- To view, visit https://gerrit.osmocom.org/2681 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I829903d7b2111ab5ee106bce52d6121204a5a401 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
