Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/3722/1/src/osmo_gsm_tester/config.py File src/osmo_gsm_tester/config.py: Line 253: dest.append(src[i]) > It is potentially dangerous to change this logic and I want to be sure I un I'll provide a a test for this, but AFAIR it fails with the same scenario of the other patch: -s encryption:cipher_a50+cipher_a51, for instance: cipher_a50.conf: bts: - ciphers: - 'a5 0' cipher_a51.conf bts: - ciphers: - 'a5 1' Combining both scenarios means you want to restrict more, ie adding more requirements for the resources. This means you should end up with the following dict, because you require to have a BTS with both ciphers: bts : { ciphers : ['a5 0', 'a5 1' } So, if I understand correctly, in essence we are doing the union for scenarios dictionaries in order to have a bigger set which will then provide a smaller intersection against resources (only BTs having both ciphers are selected). Before this patch, the code basically fails to combine the two scenarios. -- To view, visit https://gerrit.osmocom.org/3722 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7a38f10eb9de338a77bf1fa3afceb9df1532015 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
