Patch Set 3: Code-Review+2 (2 comments)
https://gerrit.osmocom.org/#/c/3722/3/selftest/config_test.ok File selftest/config_test.ok: Line 113: {'times': '1', 'label': 'foo', 'trx': [{'nominal power': '10'}, {'nominal power': '12'}], 'type': 'osmo-bts-trx'} (just wondering, this requirement of two distinct nominal power values is not solvable, right?) https://gerrit.osmocom.org/#/c/3722/3/src/osmo_gsm_tester/config.py File src/osmo_gsm_tester/config.py: Line 252: if t == dict or t == list or t == tuple: cosmetic hint: if t in (dict, list, tuple) -- To view, visit https://gerrit.osmocom.org/3722 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7a38f10eb9de338a77bf1fa3afceb9df1532015 Gerrit-PatchSet: 3 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: Yes
