Patch Set 2: I agree with both the conclusions.
One thing that jumps at me: at the time we are combining scenarios, are the 'times' entries still in there? Because this 'times' is just a convenience gimmick. To work correctly, I think we need to expand the 'times' things first, before combining with more scenarios. There is code in some place that takes each dict having a 'times: N' in there and simply replicates it to have N identical dicts next to each other. If not there already, we may have to move this expansion to right after parsing each scenario yaml. -- To view, visit https://gerrit.osmocom.org/3722 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7a38f10eb9de338a77bf1fa3afceb9df1532015 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-HasComments: No
