Patch Set 1: (1 comment)
> (1 comment) > > Please clarify, does the new MGW need this at all? Is this only for > bsc-nat? So far I thought the new MGW allocates ports as it sees > fit and communicates the right port numbers back to the client(s), > hence these functions would not be needed. > > Please clarify, why is it not possible to include mgcp.h when > mgcp_client.h is already included? They should both be completely > separate now, besides mgcp_common.h. I see: I have tried: #include <osmocom/mgcp_client/mgcp_client.h> #include <osmocom/mgcp/mgcp.h> this worked so far. https://gerrit.osmocom.org/#/c/4237/1/include/osmocom/mgcp/mgcp_calc.h File include/osmocom/mgcp/mgcp_calc.h: Line 1: /* Helpers to calculate ports and endpoints */ > This header can be used by both libraries without linking conflicts because Done -- To view, visit https://gerrit.osmocom.org/4237 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a553e863701d3bafa7b8dc17a503455c303546e Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: Yes
