Patch Set 6: > No, the new MGW does not make use of these functions.
Anything that's not used by the new osmo-mgw shouldn't be part of libosmo-mgcp. Either remain in libosmo-legacy-mgcp if only used by old programs, or, if they are still used/going to be used by other binaries after they moved to the new libosmo-sigtran, they can go into libosmo-mgcp-client. But I hope I'm not missing anything, particularly, I haven't wrapped my head around the future of osmo-bsc_nat or whether/how we will replace osmo-bsc_mgcp. Anyway, it seems good to keep legacy ways in the legacy library as much as possible; anything using the new libosmo-mgcp should use the port numbers returned upon CRCX, right? Hence we need no magic port calculation for libosmo-mgcp and neither for libosmo-mgcp-client? How did this patch come about? For which caller? -- To view, visit https://gerrit.osmocom.org/4237 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a553e863701d3bafa7b8dc17a503455c303546e Gerrit-PatchSet: 6 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: No
