Patch Set 6: > Please clarify, does the new MGW need this at all? Is this only for > bsc-nat? So far I thought the new MGW allocates ports as it sees > fit and communicates the right port numbers back to the client(s), > hence these functions would not be needed.
No, the new MGW does not make use of these functions. How do we proceed now? Remove them from mgcp_common.h again and put them into a separate file in mgcp_client? -- To view, visit https://gerrit.osmocom.org/4237 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a553e863701d3bafa7b8dc17a503455c303546e Gerrit-PatchSet: 6 Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-HasComments: No
