Patch Set 4: Code-Review+1 (2 comments)
(apologies if I'm asking stupid questions, am not so familiar with this part of the code) https://gerrit.osmocom.org/#/c/4292/4/include/osmocom/core/bitvec.h File include/osmocom/core/bitvec.h: Line 75: int bitvec_write_field_ext(struct bitvec *bv, uint32_t *write_index, uint64_t val, uint8_t len, bool use_lh); can the caller use the new bitvec_set_u64() instead? https://gerrit.osmocom.org/#/c/4292/4/tests/bits/bitfield_test.ok File tests/bits/bitfield_test.ok: Line 12: === total 1 bits differ === is this ok?? -- To view, visit https://gerrit.osmocom.org/4292 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee648d764de9f3e7ef850f40864ad701c83f61db Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
