Patch Set 8: > > I am applying new bitvec_write_field_ext function for encoding LH > bits of IA Rest OCtets of EDGE PKT DL IMM ASS in PCU. > > Could you please share your patch for OsmoPCU? Let's see if we can > use L/H directly as a parameter in separate function instead of > extending this one. Or maybe get rid of the function altogether and > manually update wp.
Basically, I replaced encoding of "HH", "H" using bitvec_write_field by bitvec_write_field_ext (with use_lh = true) in write_ia_rest_downlink and write_ia_rest_uplink in PCU project. For sure, I will submit the patch to PCU project after finish my current task. -- To view, visit https://gerrit.osmocom.org/4292 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee648d764de9f3e7ef850f40864ad701c83f61db Gerrit-PatchSet: 8 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
