Patch Set 4: (1 comment)
If I understood the issue correctly, than this 1-bit difference is what's required (the absence of it caused the issue). Minh? > can the caller use the new bitvec_set_u64() instead? Yes, and I think eventually we should. But this would require massive change to OsmoPCU encoding routines which I think is better to postpone till we have better test coverage and GPRS-related test automation. https://gerrit.osmocom.org/#/c/4292/4/tests/bits/bitfield_test.ok File tests/bits/bitfield_test.ok: Line 12: === total 1 bits differ === > is this ok?? Yes, that's the whole point of this patch series. -- To view, visit https://gerrit.osmocom.org/4292 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee648d764de9f3e7ef850f40864ad701c83f61db Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
