Patch Set 3: > this looks to me like it is imitating a "real" function from libosmocore.
It's not. There's similar code in OsmoPCU. > Is there one? No. > Will it become one? I don't see the need for it unless we'll introduce similar code somewhere besides OsmoPCU. Maybe in some distant future when we'll add GPRS support to OsmocomBB. -- To view, visit https://gerrit.osmocom.org/4336 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee544256b8675bc62a42493aab66a8eeee54f90 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
