Patch Set 3: > certainly nicer to not test a duplicate that may go out of sync
We do not test "duplicate" we test bitvec_write_field() so it does not matter if code in the test differs from code in OsmoPCU (it probably already is). As long as bitvec_write_field() works as expected, the code in OsmoPCU will continue to work. -- To view, visit https://gerrit.osmocom.org/4336 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee544256b8675bc62a42493aab66a8eeee54f90 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
