Patch Set 3: > > this looks to me like it is imitating a "real" function from > libosmocore. > > It's not. There's similar code in OsmoPCU.
Ah, so it *is* some sort of code dup? Hmm, from another repos, that makes it harder. Maybe the test should move to, or, be copied to osmo-pcu.git as well, there using the "real" function instead of a dup? It's not super necessary, but certainly nicer to not test a duplicate that may go out of sync. -- To view, visit https://gerrit.osmocom.org/4336 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ee544256b8675bc62a42493aab66a8eeee54f90 Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
