Patch Set 3: (1 comment)
> why the extensive move / separate files are needed There's a ticket about getting rid of BTS singleton so this seems like a good opportunity to move it. Besides, once it does not operate on BTS members it has nothing to do with it so it's better to put this into separate file. https://gerrit.osmocom.org/#/c/4411/3/src/bts.h File src/bts.h: Line 220: struct rate_ctr_group *ctrs; > curious, any reason to place it squarely in the middle between lots of unre Where would you prefer to see it? -- To view, visit https://gerrit.osmocom.org/4411 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf557d21552d9ff1d6b595b0594f2c7b18db4692 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
