Patch Set 9: Code-Review-1 The pcu was an example what happens if everyone is touching everyones members all the time. Making the ctr such a pointer again seems like a step back. The oddest part is that the BTS doesn't create the counter anymore but would free it? If it can delete it, why can't it create it?
If you want to make it global that will probably work as well (tests could reset values to 0 if they are interested in the delta). -- To view, visit https://gerrit.osmocom.org/4411 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf557d21552d9ff1d6b595b0594f2c7b18db4692 Gerrit-PatchSet: 9 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: No
