Patch Set 8: (4 comments)
https://gerrit.osmocom.org/#/c/4411/8/src/bts.cpp File src/bts.cpp: Line 54 I'm not really sure what this is actually all about, but was the removal of the comment intentional? https://gerrit.osmocom.org/#/c/4411/8/src/pcu_ctr.c File src/pcu_ctr.c: Line 22: #include "pcu_ctr.h" why not have the static const array here? https://gerrit.osmocom.org/#/c/4411/8/src/pcu_ctr.h File src/pcu_ctr.h: Line 32: static const struct rate_ctr_desc bts_ctr_description[] = { why do we have a 'static const' array in a header file? any file including this header file would get another copy of that array, is that what you intend? https://gerrit.osmocom.org/#/c/4411/8/src/pcu_main.cpp File src/pcu_main.cpp: Line 33: #include "pcu_ctr.h" now we have the static const array also here in pcu_main.o, not just in pcu_ctr.o? why would pcu_main.o need the array definition? all it needs is pcu_ctr_init(), rihgt? -- To view, visit https://gerrit.osmocom.org/4411 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf557d21552d9ff1d6b595b0594f2c7b18db4692 Gerrit-PatchSet: 8 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-HasComments: Yes
