dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 )
Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 16: (6 comments) The patch is quite large. I think it will need some cleanup here and there. I have tested this with TTCN3 and my test network. It seems to work fine. I saw TC_two_crcx_and_rtp_osmux_bidir_ipv6_ipv4 and TC_two_crcx_mdcx_and_rtp_osmux_ipv6_ipv4 failing though, but that may also be a local issue. It probably may make sense to add a section about how to configure threads to the manual. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16//COMMIT_MSG@65 PS16, Line 65: Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Please do not forget to ad the SYS# ticket number. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16//COMMIT_MSG@66 PS16, Line 66: Please do not forget to add dependencies: Depends: libosmocore Id8405099e6b316c2e14fb0c9b3c5e80a68a91277 (makes it easier if reviewers want to try this out) https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/include/osmocom/mgcp/mgcp_threads.h File include/osmocom/mgcp/mgcp_threads.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/include/osmocom/mgcp/mgcp_threads.h@62 PS16, Line 62: }; maybe struct mgcp_request_data should go into mgcp_protocol.h. At least thats where I would expect it to be when looking for it. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/src/libosmo-mgcp/mgcp_protocol.c@475 PS16, Line 475: #if 0 Is there any problem with that part? It should not interfere much much with the threads since it exists early without doing anything. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/src/libosmo-mgcp/mgcp_threads.c File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/src/libosmo-mgcp/mgcp_threads.c@334 PS16, Line 334: ssize_t srv = sendto(returnfd, ret->l2h, msgb_l2len(ret), 0, &w.x.addr.u.sa, sizeof(w.x.addr)); unused? maybe you plan to use it... https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/src/osmo-mgw/mgw_main.c File src/osmo-mgw/mgw_main.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/src/osmo-mgw/mgw_main.c@192 PS16, Line 192: int i; now unused (you have removed the for loop where it was used) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 16 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Comment-Date: Mon, 13 Sep 2021 11:27:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
