Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 )
Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 24: (2 comments) > Patch Set 16: > > (6 comments) > > The patch is quite large. I think it will need some cleanup here and there. I > have tested this with TTCN3 and my test network. It seems to work fine. I saw > TC_two_crcx_and_rtp_osmux_bidir_ipv6_ipv4 and > TC_two_crcx_mdcx_and_rtp_osmux_ipv6_ipv4 failing though, but that may also be > a local issue. > > It probably may make sense to add a section about how to configure threads to > the manual. Manual is missing since there is apparently still a lot to discuss... https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/include/osmocom/mgcp/mgcp_threads.h File include/osmocom/mgcp/mgcp_threads.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/include/osmocom/mgcp/mgcp_threads.h@62 PS16, Line 62: }; > maybe struct mgcp_request_data should go into mgcp_protocol.h. […] I've put it here since it is now part of the threading feature, and only used as part of the messages passed to the threads after partially parsing the request. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/src/libosmo-mgcp/mgcp_protocol.c File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/16/src/libosmo-mgcp/mgcp_protocol.c@475 PS16, Line 475: #if 0 > Is there any problem with that part? It should not interfere much much with > the threads since it exi […] This is related to the discovery that the endp find part did not work as expected, because the rq.endp = mgcp_endp_by_name_trunk(&rc, pdata.epname, rq.trunk); call returns empty usable eps if the req is wildcaded - even in the case of a dlcx * or something like that, so basically in cases where there should not be a EP nor should one be required. Addiotnally the error codes returned so far differ depending on the actual mgcp command, so this was reworked and basically keeps the current error codes (and therefore behavior related to the ttcn3 tests) while making sure it now works as expected. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 24 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Comment-Date: Mon, 13 Sep 2021 17:49:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <[email protected]> Gerrit-MessageType: comment
