pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25432 )
Change subject: Add multithreading for the virtual trunk ...................................................................... Patch Set 24: (2 comments) Most of my previous comments have not been addressedyet in this new version. It may make sense to first write a patch doing the proper split of the data model in MGCP dispatcher + workers with no threading involved, and then a follow up commit adding the multithread stuff. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/24/include/osmocom/mgcp/mgcp_threads.h File include/osmocom/mgcp/mgcp_threads.h: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/24/include/osmocom/mgcp/mgcp_threads.h@113 PS24, Line 113: static_assert(sizeof(struct to_trunkthread_mgcp_msg) == 4096, "interthread struct size mismatch!"); We do have osmo_static_assert(), implemented differently, not sure if we need it for some compiler compat. https://gerrit.osmocom.org/c/osmo-mgw/+/25432/24/src/libosmo-mgcp/mgcp_threads_vty.c File src/libosmo-mgcp/mgcp_threads_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25432/24/src/libosmo-mgcp/mgcp_threads_vty.c@165 PS24, Line 165: * types when implementation is available */ wrong indentation -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I31be8253600c8af0a43c967d0d128f5ba7b16260 Gerrit-Change-Number: 25432 Gerrit-PatchSet: 24 Gerrit-Owner: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Comment-Date: Tue, 14 Sep 2021 09:27:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
