neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 )
Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25973/1/include/osmocom/bsc/time_cc.h File include/osmocom/bsc/time_cc.h: https://gerrit.osmocom.org/c/osmo-bsc/+/25973/1/include/osmocom/bsc/time_cc.h@129 PS1, Line 129: struct time_cc { > Maybe add an API to allocate/initialize a structure for this. Hmm, the usage example above this line actually lacks mention of talloc_zero(). There is no init needed besides bzero(). will add that. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Wed, 27 Oct 2021 21:09:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
