neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 )
Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: > Let's let other specialized systems do this kind of stuff instead of bloating > our code base. I'm not blocking this if still others think it is a good idea > to have this merged. Let's identify which bloat can be removed. Maybe I'm not seeing it because I wrote the code? The only simplification that I see is hardcoding time_cc to a granularity period of one second, and not allowing a round threshold / forget-sum config. Switching to a stat_item per se does not remove any of this code at all. Most of this is about keeping track of a flag over time. Oh, you mean we should just export the flag as 0 or 1, and not count it over time at all? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 02 Nov 2021 16:09:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
