pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 )
Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: > Patch Set 1: > For all_allocated, it is the number of seconds that all channels were > allocated per a given amount of time. For example, if the VTY shows > all_allocated:sdcch of 10/min, it means all channels were allocated for 10 > seconds of the last minute. For a stat item, getting this "per time" part is > a complex problem. Thanks, this is the kind of example I was asking for on my first comments in order to understand better what you want to achieve. > > So I'm not really following on why you need all this infrastructure sorry, > > I would appreciate if your criticism could be qualified as well as > constructive. > What do you mean by "all this"? What do you suggest instead? Maybe the problem is that I don't see this may be the correct way to go here. I have the feeling we are adding too much counting complexity inside our code base, where this can be simply be submitted over time as a osmo_stat item counter, and let whatever system the customer uses to plot the data over time (eg using grafana or some custom statsd/python scripts) and see when the all_allocated:sdcch incremented over time. So that's what I'm suggesting. Let's let other specialized systems do this kind of stuff instead of bloating our code base. I'm not blocking this if still others think it is a good idea to have this merged. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 02 Nov 2021 11:05:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
