pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 )
Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: Configurability features: Ok fine to keep them. So AFAIU the problem boils down to not wanting an ever increasing value, which means stat_item would need to be reset to 0 when you stop counting, but then sub-period increases would be lost (not announced/visible to statsd). Fine then, please do the documentation improvements you already ACKed. I'd really add structure wrappers to allocate/free the struct, so that users don't need to care about details and we can later on expand them as we see is needed. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Thu, 04 Nov 2021 13:01:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
