pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25973 )
Change subject: add time_cc API: cumlative counter for time, reported as rate_ctr ...................................................................... Patch Set 1: Well the question would then be: Can one still use the same external tools (grafana, elastic search, etc) with rate_ctr? I'm not sure how are those exported over statsd. In general I think the main difference on how we see it, is that your focus is to have it look nice when using VTY, while my point is that it should in first place be usable for external tools. Moreover, I have the feeling you are just abusing the rate_ctr infrastructure with some logic just to get some output in VTY which you can understand (rate_ctr is aimed at tick events, not counting time). I think we should go into the direction of doing the least possible to output data and then let other tools/technologies to the thing. That being said, I'm happy to hear opinions from others, I'm open to comments and I'll accept whatever the consensus ends up being. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25973 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icdd36f27cb54b2e1b940c9e6404ba9dd3692a310 Gerrit-Change-Number: 25973 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 02 Nov 2021 18:24:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
