Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/simtrace2/+/26985 )
Change subject: contrib/simtrace.lua: Add Flag bits + Data to COL_INFO ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File contrib/simtrace.lua: https://gerrit.osmocom.org/c/simtrace2/+/26985/comment/485c53ea_228e3edc PS1, Line 93: if is_pbrx().value == 1 then Using ternary operator may improve readability here: flagstr = flagstr + if is_pbrx().value == 1 then "R" else "." end -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26985 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I0aa3d68172022907fbe8371aaca6538df0649dfe Gerrit-Change-Number: 26985 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Comment-Date: Tue, 25 Jan 2022 18:58:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
