laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26985 )

Change subject: contrib/simtrace.lua: Add Flag bits + Data to COL_INFO
......................................................................

contrib/simtrace.lua: Add Flag bits + Data to COL_INFO

this provides an esy way to understand more without looking at the
detailed decode for each packet.

Change-Id: I0aa3d68172022907fbe8371aaca6538df0649dfe
---
M contrib/simtrace.lua
1 file changed, 24 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/simtrace.lua b/contrib/simtrace.lua
index fadc01a..9015085 100644
--- a/contrib/simtrace.lua
+++ b/contrib/simtrace.lua
@@ -114,6 +114,30 @@
   headerSubtree:add(rxtxdatalen, len)
   headerSubtree:add_le(rxtxdata, payload_data(6,len))

+  local flagstr = " "
+  if is_pbrx().value == 1 then
+    flagstr = flagstr .. "R"
+  else
+    flagstr = flagstr .. "."
+  end
+  if is_pbtx().value == 1 then
+    flagstr = flagstr .. "T"
+  else
+    flagstr = flagstr .. "."
+  end
+  if is_final().value == 1 then
+    flagstr = flagstr .. "F"
+  else
+    flagstr = flagstr .. "."
+  end
+  if is_hdr().value == 1 then
+    flagstr = flagstr .. "H"
+  else
+    flagstr = flagstr .. "."
+  end
+  flagstr = flagstr .. " "
+  pinfo.cols.info:append(flagstr .. payload_data(6,len))
+
   -- ghetto dissection does not work due to mixed in procedure bytes
   --if pinfo.visited == false then
   -- Dissector.get("iso7816"):call(payload_data(6):tvb(), pinfo, tree)

--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26985
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I0aa3d68172022907fbe8371aaca6538df0649dfe
Gerrit-Change-Number: 26985
Gerrit-PatchSet: 6
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged

Reply via email to