Attention is currently required from: fixeria.
laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/simtrace2/+/26985 )

Change subject: contrib/simtrace.lua: Add Flag bits + Data to COL_INFO
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

File contrib/simtrace.lua:

https://gerrit.osmocom.org/c/simtrace2/+/26985/comment/6d630fda_a6751bb6
PS1, Line 93:   if is_pbrx().value == 1 then
> Interesting, I don't even remember where I found that syntax. Now I found: […]
"Attempt to perform arithmetic on locla 'flagstr' (a string value).

and with .. instead of + it is a different value.

I'm now going to merge this as-is, as your suggestions don't appear to work.



--
To view, visit https://gerrit.osmocom.org/c/simtrace2/+/26985
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: simtrace2
Gerrit-Branch: master
Gerrit-Change-Id: I0aa3d68172022907fbe8371aaca6538df0649dfe
Gerrit-Change-Number: 26985
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 03 Mar 2022 18:04:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to