Patch Set 10: I'd like to use similar API as well. Which way is better: 1) change gsm0503_rach_encode() to match gsm0503_rach_ext_encode()? 2) change gsm0503_rach_ext_encode() to match gsm0503_rach_encode()? 3) add wrapper with (bool is_11bit) parameter?
I don't know of code using gsm0503_rach_encode() and api with pointer just to pass single byte looks gnarly so I'd rather go for 1 or 3. -- To view, visit https://gerrit.osmocom.org/5062 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85a34a82d5cd39a594ee89d91a2338226066ab5d Gerrit-PatchSet: 10 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-HasComments: No
