Patch Set 10: > May we use OSMO_ASSERT here?
We may but we shouldn't: assert tells us nothing except that the test has somehow failed. By printing we immediately got useful logs which saves time in case of using jenkins check via gerrit or if there're multiple failures, which would be masked by 1st error triggering assert. -- To view, visit https://gerrit.osmocom.org/5062 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85a34a82d5cd39a594ee89d91a2338226066ab5d Gerrit-PatchSet: 10 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-HasComments: No
