Patch Set 11: Code-Review-1 (2 comments)
Hi Max! I like this change very much, and wish to move it forward. But I insist to keep the API as similar and easy to use as possible. https://gerrit.osmocom.org/#/c/5062/11/include/osmocom/coding/gsm0503_coding.h File include/osmocom/coding/gsm0503_coding.h: Line 72: int gsm0503_rach_ext_decode(uint16_t *ra, const sbit_t *burst, uint8_t bsic); I don't like the mix of both '_encode_ext' and '_ext_decode'. Let's use the common 'gsm0503_CODE_(en/de)code' style. https://gerrit.osmocom.org/#/c/5062/11/utils/conv_codes_gsm.py File utils/conv_codes_gsm.py: Line 57: name = "ext_rach", Here we have 'ext_rach', while the coding API provides 'rach_ext'. It may cause potential API users to confuse between different names. I suggest to use 'rach_ext' everywhere. -- To view, visit https://gerrit.osmocom.org/5062 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85a34a82d5cd39a594ee89d91a2338226066ab5d Gerrit-PatchSet: 11 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-HasComments: Yes
